Skip to content

Config param placeholders - #193

Merged
mschwoer merged 8 commits into
mainfrom
config_param_placeholders
Sep 11, 2026
Merged

Config param placeholders#193
mschwoer merged 8 commits into
mainfrom
config_param_placeholders

Conversation

@mschwoer

@mschwoer mschwoer commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Use braces as placeholder delimiters.

Note: will become double-braces in a later PR.

BREAKING: adapt all settings that use placeholders

mschwoer and others added 6 commits August 27, 2026 13:30
---
# Conversation that produced these changes
---

## User prompt

"the placeholders for introducing custom commands should be surrounded by "{}" @airflow_src/dags/impl/processor_impl.py#L254-264"

## Clarifying round 1

Q: Existing settings in the DB use bare placeholders (RAW_FILE_PATH). After the switch to {RAW_FILE_PATH} they silently stop substituting. How should this be handled?
  - Fail loudly on leftovers
  - Clean break, no guard  <-- chosen
  - Accept both syntaxes

Q: Braces have to be allowed through check_for_malicious_content. Which scope?
  - New allow_placeholders flag
  - Add {} to the with-spaces pattern
  - Other  <-- chosen: "validate after substitution only"

## User prompt

"decision 2: the webapp should know which parameters exists and to a "dummy substitution" before validating"

## Clarifying round 2

Q: Where should the placeholder registry live, and should the webapp help list be generated from it?
  - New shared/config_params.py, generated help  <-- chosen
  - New module, hand-written help
  - Put it in shared/keys.py

## User prompt

"check again that all your desired changes are there"

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
# Conflicts:
#	webapp/pages_/settings.py
@mschwoer mschwoer added the breaking-change Change requires a DB migration or similar label Aug 27, 2026
@claude

claude Bot commented Aug 27, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@mschwoer
mschwoer merged commit c04939a into main Sep 11, 2026
4 checks passed
@mschwoer
mschwoer deleted the config_param_placeholders branch September 11, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Change requires a DB migration or similar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant